workflows/release: use PyPI trusted publisher #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fg-aqt
approved these changes
Oct 17, 2023
mtreinish
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
This LGTM, I'm planning to hopefully migrate the pypi account on Wednesday (tomorrow), so as long as you aren't planning any releases before then we can merge this whenever (it only will work after the migration though). I'll add aqt-admin as a co-owner on the pypi project at the same time.
|
Just a heads up I took care of the migration earlier today, so you should be good to use the trusted publisher mechanism now. I also sent an invite to the aqt-admin user to be a co-owner on the project. |
|
Awesome, thanks a lot! We'll test this with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #86.
@mtreinish could you please add this repository as a trusted publisher for qiskit-aqt-provider? or, better, add the aqt-admin as co-maintainer of the project, such that we can administrate the PyPI project directly? Thanks!