Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename debiasing + backend #124

Merged
merged 6 commits into from May 11, 2023
Merged

rename debiasing + backend #124

merged 6 commits into from May 11, 2023

Conversation

splch
Copy link
Collaborator

@splch splch commented May 5, 2023

Summary

Renames symmetrization to debiasing, updates the v0.3 backend naming scheme, and adds a extra_request_payload for specifying post / get parameters

Details and comments

Screenshot 2023-05-09 at 9 18 11 AM

SYMMETRIZATION = {"symmetrization": True}
NO_SYMMETRIZATION = {"symmetrization": False}
DEBIASING = {"debias": True}
NO_DEBIASING = {"debias": False}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that this requires SDK-side updates if we offer new error mitigation settings.

Is it possible to pass in an arbitrary JSON object for error_mitigation ? Can we support that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im fine with that but then we need to have a source of clear documentation of error mitigation settings that we support - that could be https://docs.ionq.com/#tag/jobs under error_mitigation. ill add that as well to the readme

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping me on the docs change if you don't mind; mostly curious on the process for rolling those out

qiskit_ionq/ionq_client.py Outdated Show resolved Hide resolved
qiskit_ionq/ionq_job.py Outdated Show resolved Hide resolved
qiskit_ionq/helpers.py Outdated Show resolved Hide resolved
self,
job_id: str,
sharpen: Optional[bool] = None,
extra_request_payload: Optional[dict] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, sorry... when I saw that this was updating a dict I thought it was part of the jobs payload. extra_query_params does seem more appropriate (sorry to back and forth so much, this field being optional means folks will need to use its name to reference it so I'm a bit fixated on it at the moment).

@splch splch merged commit 0824250 into main May 11, 2023
11 checks passed
@splch splch deleted the symmetrization-to-debiasing branch May 11, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants