Added missing had_transpiled=True to quantum_kernel #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnktysz
requested review from
adekusar-drl,
manoelmarques,
pbark,
stefan-woerner and
woodsp-ibm
as code owners
|
|
adekusar-drl
approved these changes
Oct 20, 2021
gentinettagian
pushed a commit
to gentinettagian/qiskit-machine-learning
that referenced
this pull request
Dec 14, 2021
…#247) * Added missing had_transpiled=True * added missing reno file * add missing words * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Circuits are being transpiled in
quantum_kernel.pybut the necessaryhad_transpiled=Trueflag is not being passed when the circuits are being executed. This makes the transpilation operation re-run many times and this slows down the QSVM algorithm.Details and comments
A test with the IRIS dataset is performed for 10 data samples from 2 classes is performed. Run times are given below:
Before the change: 55.0 seconds
After the change: 5.56 seconds