Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used trusted publisher for PyPi #698

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Used trusted publisher for PyPi #698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9da35f
Used trusted publisher for PyPi
woodsp-ibm Oct 12, 2023
34781f1
Merge branch 'main' into pypi
mergify[bot] Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions .github/workflows/deploy-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ on:
jobs:
code_publish:
runs-on: ubuntu-latest
environment: release
permissions:
id-token: write
strategy:
matrix:
python-version: [3.8]
Expand All @@ -28,12 +31,12 @@ jobs:
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Install deps
run: pip install -U pip setuptools virtualenv wheel
- name: Build sdist
run: python3 setup.py sdist bdist_wheel
Comment on lines +35 to +37
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The future proof way to do this is to use:

Suggested change
run: pip install -U pip setuptools virtualenv wheel
- name: Build sdist
run: python3 setup.py sdist bdist_wheel
run: pip install -U pip setuptools build
- name: Build sdist
run: python3 -m build .

but for now this works fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sounds good for the future.

- uses: actions/upload-artifact@v3
with:
path: ./dist/*
- name: Deploy to Pypi
env:
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
TWINE_USERNAME: qiskit
run : |
pip install -U twine pip setuptools virtualenv wheel
python3 setup.py sdist bdist_wheel
twine upload dist/qiskit*
shell: bash
uses: pypa/gh-action-pypi-publish@release/v1