Unify orbital ordering of FermiHubbardModel with ElectronicEnergy…
#1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ialsina
requested review from
stefan-woerner,
woodsp-ibm and
mrossinek
as code owners
|
|
mrossinek
requested changes
Sep 6, 2023
There was a problem hiding this comment.
While I think that this change is - in principle - good as it is, you will need to address the following things before we can merge this:
- fix the currently existing unittests which should fix the CI, too
- add a release note (see
CONTRIBUTING.mdon how to do that)
And as a bonus:
- It would be nice if you could also add a new unittest which asserts that using
InterleavedQubitMapper(JordanWignerMapper())is actually reproducing the original behavior.
ialsina
force-pushed
the
fix-fermi-hubbard-model
branch
from
deffea4
to
ecce6f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #1224. This commit changes the orbital ordering of the
FermiHubbardModelto make it consistent with the block-ordering of theElectronicEnergyclass.Details and comments
With this change,
JordanWignerMapperproduces block encoding when mapping the second quantization hamiltonian ofFermiHubbardModel.InterleavedQubitMapperacting onJordanWignerMapperproduces interleaved encoding. See full description in the original issue.