New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactoring #142
Code refactoring #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the code is now released changes to public interfaces need to be deprecated. So for example it seems to me for instance a new method would need to be added to replace the old one that returns a List whereby that one is deprecated and the user is referred to the new.
Since there is also discussion in changing VQE (ie min eigen solvers) - to say allow a dictionary instead of List - do we want to delay changing things until that is done since this seems to be related since ultimately these need to get passed to VQE?
qiskit_nature/problems/second_quantization/problem_second_quant_ops.py
Outdated
Show resolved
Hide resolved
qiskit_nature/problems/second_quantization/problem_second_quant_ops.py
Outdated
Show resolved
Hide resolved
Sure, let's wait and see how the situation develops. Good point about deprecations - I will rely on your suggestions there. |
Summary
Introduces a little bit of structure to second quantized operators generated by problems.
Details and comments
It deals with a bad practice of addressing the main operator via an index. In the future we might want to think about introducing even more structure by subclassing for example, depending on the problem at hand.
Let me know if you have better ideas for naming.