Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #142

Closed
wants to merge 14 commits into from
Closed

Conversation

dlasecki
Copy link
Contributor

Summary

Introduces a little bit of structure to second quantized operators generated by problems.

Details and comments

It deals with a bad practice of addressing the main operator via an index. In the future we might want to think about introducing even more structure by subclassing for example, depending on the problem at hand.
Let me know if you have better ideas for naming.

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the code is now released changes to public interfaces need to be deprecated. So for example it seems to me for instance a new method would need to be added to replace the old one that returns a List whereby that one is deprecated and the user is referred to the new.

Since there is also discussion in changing VQE (ie min eigen solvers) - to say allow a dictionary instead of List - do we want to delay changing things until that is done since this seems to be related since ultimately these need to get passed to VQE?

@dlasecki
Copy link
Contributor Author

Since the code is now released changes to public interfaces need to be deprecated. So for example it seems to me for instance a new method would need to be added to replace the old one that returns a List whereby that one is deprecated and the user is referred to the new.

Since there is also discussion in changing VQE (ie min eigen solvers) - to say allow a dictionary instead of List - do we want to delay changing things until that is done since this seems to be related since ultimately these need to get passed to VQE?

Sure, let's wait and see how the situation develops. Good point about deprecations - I will rely on your suggestions there.

@dlasecki dlasecki marked this pull request as draft April 15, 2021 15:07
@pbark pbark added the on hold Can not fix yet label May 5, 2021
@mrossinek
Copy link
Member

The idea of the ProblemSecondQuantizedOps class will largely be implemented by the Property objects introduced in #220. In combination with the planned step of #243 this should mostly alleviate the need for this PR, right? @dlasecki

@dlasecki
Copy link
Contributor Author

The idea of the ProblemSecondQuantizedOps class will largely be implemented by the Property objects introduced in #220. In combination with the planned step of #243 this should mostly alleviate the need for this PR, right? @dlasecki

Yes, I agree. Let's close this.

@dlasecki dlasecki closed this Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Can not fix yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants