Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase num qubit for grover bit ordering unit test #130

Closed
wants to merge 1 commit into from

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented May 13, 2021

Summary

Follow-up of #97

I notice that a unit test may fail on Linux as follows.

======================================================================
FAIL: test_bit_ordering_1_sv (test.algorithms.test_grover_optimizer.TestGroverOptimizer)
Test bit ordering
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ima/envs/dev/lib/python3.8/site-packages/ddt.py", line 182, in wrapper
    return func(self, *args, **kwargs)
  File "/home/ima/qiskit/opt/test/algorithms/test_grover_optimizer.py", line 236, in test_bit_ordering
    self.assertEqual(results.fval, opt_sol)
AssertionError: 0.0 != -2
----------------------------------------------------------------------

It is required to make #129 pass.

Details and comments

@t-imamichi t-imamichi added the on hold Can not fix yet label May 13, 2021
@t-imamichi t-imamichi marked this pull request as draft May 13, 2021 14:11
@t-imamichi
Copy link
Collaborator Author

We need more investigation because @manoelmarques runs CI again with #129 and we found that CI succeeds without this PR. It looks strange...
https://github.com/Qiskit/qiskit-optimization/runs/2575783380

@t-imamichi
Copy link
Collaborator Author

I close it because we implemented a better solution #132.

@t-imamichi t-imamichi closed this May 14, 2021
@t-imamichi t-imamichi deleted the fix-grover-test branch May 17, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Can not fix yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants