Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New authentication #12

Merged
merged 15 commits into from
Oct 16, 2020
Merged

Conversation

dlucchetti
Copy link
Contributor

Summary

Details and comments

@dlucchetti dlucchetti marked this pull request as ready for review July 9, 2020 17:21
Copy link
Collaborator

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only quickly skimmed this PR because a lot of it is just #11. I'll do a more thorough review once it's rebased after #11 merges. Just some quick inline comments.

requirements.txt Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
test/test_honeywellbackend.py Show resolved Hide resolved
@dlucchetti
Copy link
Contributor Author

Any additional actions/updates needed?

Copy link
Collaborator

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in reviewing this, I've been busy with a lot of different projects and this slipped through the cracks. It LGTM just an inline comment but not really a blocker.

deps = -r{toxinidir}/requirements.txt
-r{toxinidir}/requirements-dev.txt
keyrings.alt>=3.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add this to requirement-dev.txt instead that's normally where we put the test only requirements.

test/test_honeywellbackend.py Show resolved Hide resolved
@mtreinish mtreinish merged commit cb44ea4 into qiskit-community:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants