Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Changing shebang in build and deploy scripts for better portability #1149

Merged
merged 5 commits into from Nov 29, 2022
Merged

Conversation

paniash
Copy link
Collaborator

@paniash paniash commented Jun 8, 2021

Changes made

Changed shebang in build.sh from #!/bin/bash to #!/usr/bin/env bash.

Justification

In build.sh, the bash interpreter path is provided as #!/bin/bash, which is good but only for specific systems (*nix). In other systems, this path might not be where bash exists and a reasonable shebang would be #!/usr/bin/env bash, which is much more portable. Please refer this to learn more.

@paniash paniash changed the title Changing shebang in build.sh for better portability Changing shebang in build and deploy scripts for better portability Jun 13, 2021
@divshacker
Copy link
Collaborator

Have you tested this on other systems? @paniash

@paniash
Copy link
Collaborator Author

paniash commented Oct 18, 2021

Explicitly no. But I see no reason why it shouldn't work. :-)

@divshacker
Copy link
Collaborator

@frankharkins What do you think ?

@frankharkins
Copy link
Collaborator

Really need @vabarbosa to look over.

Copy link
Collaborator

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after investigating, I'm approving; thank you!

@frankharkins frankharkins merged commit cf54a18 into qiskit-community:main Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants