This repository has been archived by the owner on May 30, 2023. It is now read-only.
Changing shebang in build
and deploy
scripts for better portability
#1149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Changed shebang in
build.sh
from#!/bin/bash
to#!/usr/bin/env bash
.Justification
In
build.sh
, the bash interpreter path is provided as#!/bin/bash
, which is good but only for specific systems (*nix). In other systems, this path might not be wherebash
exists and a reasonable shebang would be#!/usr/bin/env bash
, which is much more portable. Please refer this to learn more.