Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new upgrade breaks solidity (remappings) #3

Closed
TortoiseHive opened this issue Mar 24, 2022 · 4 comments
Closed

new upgrade breaks solidity (remappings) #3

TortoiseHive opened this issue Mar 24, 2022 · 4 comments

Comments

@TortoiseHive
Copy link

TortoiseHive commented Mar 24, 2022

I was using:

"solidity.remappings": [
"@OpenZeppelin=./dependencies/openzeppelin-contracts-4.4.2",
"@chainlink=./dependencies/chainlink-brownie-contracts@1.1.1"
],

Without that, the LSP dont start (using brownie here).

Can you add this back?

OS: Mac OS

image

The LSP is not working at all

@qiuxiang
Copy link
Owner

New lsp not support remappings. Only support include_path just like official compiler solc. It looks like your dependencies directory are dependencies not node_modules. Why not just use npm to manage dependencies?

@TortoiseHive
Copy link
Author

TortoiseHive commented Mar 24, 2022

New lsp not support remappings. Only support include_path just like official compiler solc. It looks like your dependencies directory are dependencies not node_modules. Why not just use npm to manage dependencies?

brownie installs dependencies on home folder so we decided to put the dependencies in the project (to improve navigation on emacs (my coworker uses and dont have LSP yet))

Its possible to do the remappings in solc with include_path? Would be awesome if could to use the @openzepellin in the file

https://docs.soliditylang.org/en/v0.8.11/path-resolution.html#import-remapping

@qiuxiang
Copy link
Owner

Ok, if solc supports remapping, I should also support it in this lsp.

@TortoiseHive
Copy link
Author

TortoiseHive commented Mar 24, 2022

New remaps are working perfectly, thanks!

EDIT:

This new server is awesome, this is how i configured:

"solidity.remapping": {
"@OpenZeppelin": "./dependencies/openzeppelin-contracts-4.4.2"
},

@TortoiseHive TortoiseHive changed the title new upgrade breaks solidity new upgrade breaks solidity (remappings) Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants