Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: package.json contains incorrect deps versions #27

Open
antongolub opened this issue Dec 24, 2020 · 11 comments
Open

Bug: package.json contains incorrect deps versions #27

antongolub opened this issue Dec 24, 2020 · 11 comments
Labels
bug Something isn't working

Comments

@antongolub
Copy link
Member

Hey @davikawasaki @oljekechoro, I just had a quick test with the new version and it seems the issue was not completely resolved. The beta suffix is now available but the version is incorrect. The screenshot to capture the issue is attached below but the details can be found here.

Screen Shot 2020-12-24 at 1 16 01 PM

Originally posted by @zlatanpham in #25 (comment)

@antongolub
Copy link
Member Author

@zlatanpham,

Looks very similar to dhoulb/multi-semantic-release#47. At first we will try to localize the problem. Stay tuned.

@antongolub antongolub changed the title Bug: package.json contains invalid deps versions Bug: package.json contains incorrect deps versions Dec 24, 2020
@antongolub antongolub added the bug Something isn't working label Dec 24, 2020
antongolub added a commit that referenced this issue Dec 24, 2020
antongolub added a commit that referenced this issue Dec 24, 2020
qiwibot added a commit that referenced this issue Dec 24, 2020
# [3.11.0](v3.10.0...v3.11.0) (2020-12-24)

### Features

* **debug:** log manifest deps changes ([88b4077](88b4077)), closes [#27](#27)
@davikawasaki
Copy link
Contributor

@antongolub don't know if you have fixed this yet, but it seems like the way we bump local dependencies is different from the way we bump the package. Maybe we should standardize it... How are we bumping the main package (i.e. packages/apple) to 12.0.0-beta.1?

@antongolub
Copy link
Member Author

I agree, there is a rather confusing piece. Any ideas how this could be improved?

@davikawasaki
Copy link
Contributor

davikawasaki commented Dec 31, 2020

@antongolub I'll tinker on this through these holidays days and I'll let you know.

@antongolub
Copy link
Member Author

antongolub commented Jan 5, 2021

@zlatanpham, @Ellosaur

The fix is ready for testing (v3.12.2, many thanks to @davikawasaki). Could you take a look and give feedback?

@Ellosaur
Copy link

Ellosaur commented Jan 5, 2021

@antongolub as we're using "multi-semantic-release": "^2.5.3" in our project can we simply hot swap to "@qiwi/multi-semantic-release": "3.12.2" or should we wait until the fix makes it upstream to dhoulb/multi-semantic-release?

@antongolub
Copy link
Member Author

@Ellosaur,

As you wish. @qiwi-scoped msr is just like a canary build channel.

@Ellosaur
Copy link

Ellosaur commented Jan 5, 2021

Our first release since switching has upgraded the changelog and dependencies correctly.
However the second release exhibited the familiar problem:
image

@antongolub
Copy link
Member Author

antongolub commented Jan 6, 2021

@Ellosaur,

Could you show .releaserc? I need to know what plugins are used to observe how they modify package.json files.

@Ellosaur
Copy link

Ellosaur commented Jan 7, 2021

@antongolub,

Sure. We use the release section in the packages.json rather than a .releaserc. I included these on the original issue I logged dhoulb#47. Those settings haven't changed.

@Ellosaur
Copy link

Ellosaur commented Feb 2, 2021

FYI we're now using semantic-release-monorepo which doesn't attempt to update package references so it avoids this problem. We leave references as ~1.x so that the latest package is always referenced

prisis pushed a commit to anolilab/multi-semantic-release that referenced this issue Sep 28, 2023
### ⚠ BREAKING CHANGES

* semantic-release/semantic-release@v19.0.5...v21.0.5
* drop support for cycled monorepos
* require Node.js v12
* sequentialPrepare is set to true, to disable pass `--no-sequential-prepare` option
* semrel npm plugin calls local npm version semantic-release/npm#445
* **engine:** the latest semantic-release requires Node.js 10.18
* drop nodejs v8

### Features

* add --tag-version-format flag ([259864c](259864c))
* add debugger ([d2c090d](d2c090d))
* add dependencies updating controller ([0c9b040](0c9b040))
* add execa queued hook ([042933e](042933e))
* add execasync CLI flag to make execa calls be always synchronous ([693438c](693438c)), closes [#1](#1)
* add meow as cli provider ([6de93b9](6de93b9))
* add pnpm and bolt support ([91465de](91465de))
* add process.spawn arg watcher ([7699b6f](7699b6f))
* add sequential-init flag to avoid hypothetical concurrent initialization collisions ([348678e](348678e))
* add some debug messages ([ec792e1](ec792e1))
* added declarative config support ([c98ff10](c98ff10))
* allow to run prepare steps sequentially ([299748a](299748a))
* apply --first-parent filter to commits ([14a896b](14a896b))
* apply queuefy to plugin methods instead of execa ([9ae7d0d](9ae7d0d))
* bump semrel to v19 ([e6b8acb](e6b8acb))
* check that sequentialPrepare is not enabled on cyclic projects ([68c1198](68c1198))
* **debug:** attach pkg prefixes to debug notes ([25e111f](25e111f))
* **debug:** log manifest deps changes ([88b4077](88b4077)), closes [qiwi#27](https://github.com/anolilab/multi-semantic-release/issues/27)
* **debug:** print passed cli flags ([d720cd7](d720cd7))
* drop nodejs v8 support ([80f0a24](80f0a24))
* enable `sequentialPrepare` flag by default ([ad7e81f](ad7e81f))
* enable first-parent commits filtering by cli flag ([33306cc](33306cc))
* **engine:** up nodejs version ([10af385](10af385))
* handle .cjs configs ([38f657a](38f657a))
* ignore packages to be released with workspaces and CLI ([qiwi#42](https://github.com/anolilab/multi-semantic-release/issues/42)) ([b98e181](b98e181))
* Initial commit ([942ef94](942ef94))
* introduce `deps.prefix` flag to inject carets ([c3f4529](c3f4529))
* introduce `ignorePrivate` flag ([e4891c9](e4891c9)), closes [qiwi#66](https://github.com/anolilab/multi-semantic-release/issues/66)
* introduce `log-level` config option ([3fb6584](3fb6584))
* introduce a silent mode([qiwi#88](https://github.com/anolilab/multi-semantic-release/issues/88)) ([47a27d8](47a27d8))
* let publish step run in parallel ([4d5c451](4d5c451))
* log filtered commits in debug ([c64b8e1](c64b8e1))
* log manifest path ([db451e8](db451e8))
* new updated version of the multi-semantic-release lib ([54be8b7](54be8b7))
* prefer nested CLI flags ([1bf08cc](1bf08cc))
* provide pre-release flow ([6a9ce16](6a9ce16)), closes [qiwi#25](https://github.com/anolilab/multi-semantic-release/issues/25)
* replace synchronizer with @semrel-extra/topo ([ddd1032](ddd1032))
* support `${version}+${name}` tag format ([c53fefb](c53fefb)), closes [qiwi#71](https://github.com/anolilab/multi-semantic-release/issues/71)
* support `release.config.cjs` ([a6b9370](a6b9370))
* support workspace.packages notation ([4a606b2](4a606b2))
* tech release ([828a82d](828a82d))
* update semver from v19 to v21 ([6e4c378](6e4c378))
* uphold the prev package.json indents ([ac5832f](ac5832f))

### Bug Fixes

* add flag to enable sequentialPrepare mode ([70c2dc5](70c2dc5))
* add sync point for publish step ([adc823e](adc823e))
* allow any `todo` package to run the `generateNotes` queue ([26a87d7](26a87d7)), closes [#9](#9)
* apply deps update before npm's plugin prepare ([77b6ee2](77b6ee2))
* avoid non-updated local dependencies bump ([qiwi#33](https://github.com/anolilab/multi-semantic-release/issues/33)) ([9faeef6](9faeef6))
* beautify log labels ([78cbc8a](78cbc8a))
* bump-up of pre-version  ([02ef270](02ef270))
* **cli:** fix inner spawnhook call ([70aa292](70aa292))
* **cli:** restore watchspawn context ([56145aa](56145aa))
* **config:** fix `options` and `plugins` resolver ([56e974c](56e974c))
* correct global config use ([8e5fb99](8e5fb99))
* dont fetch tags if tags arg is empty array ([3a79558](3a79558))
* ensure msr cli flags take precedence over their semrel equivalents ([2be75fa](2be75fa))
* filter only tags that are valid ([59b61ad](59b61ad))
* filter queued packages on generateNotes stage ([e0625ce](e0625ce)), closes [#6](#6)
* fix cascade bumping when some dep belongs to several levels of the dep tree ([cf20dea](cf20dea))
* fix debug logging ([71527b2](71527b2))
* fix export point ([cf31425](cf31425))
* fix getNextVersion resolver ([7275ae7](7275ae7))
* fix globbing on Windows ([qiwi#57](https://github.com/anolilab/multi-semantic-release/issues/57)) ([1d71d21](1d71d21))
* fix internal flag ref filterParent → firstParent ([8c7400f](8c7400f))
* fix logger path ([232d2dc](232d2dc))
* fix nextType resolver ([606914b](606914b))
* fix pkgOptions resolver ([2a2f0cf](2a2f0cf))
* force a release ([1e3ece5](1e3ece5))
* getVersionFromTag tests to fix release process ([e7f1646](e7f1646))
* local dependencies correct bump from release to prerelease ([qiwi#34](https://github.com/anolilab/multi-semantic-release/issues/34)) ([6481a59](6481a59))
* make logger to be singleton ([1790794](1790794))
* missing @ in tagFormat ([3faa0f1](3faa0f1))
* more robust stream rescoping (to fix bug in npm module) ([34c7c62](34c7c62))
* override env.TRAVIS_PULL_REQUEST_BRANCH to fix PR checks on travis-ci ([e4b1929](e4b1929)), closes [#11](#11)
* **package:** add missed sem-rel plugins ([f3c9318](f3c9318))
* **package:** up deps, fix some vuls ([d8905b0](d8905b0))
* **package:** up deps, fix vulns ([5a4d91e](5a4d91e))
* **package:** update execa to be compatible with sem-rel 15.13.28 ([069bb4e](069bb4e)), closes [#7](#7)
* pass stderr and stdout into semantic's getConfig (bug in npm) ([cf596cb](cf596cb))
* pin npm as peer dep ([67d8b80](67d8b80))
* pin npm version to v8.4.1 ([22c89d1](22c89d1)), closes [qiwi#60](https://github.com/anolilab/multi-semantic-release/issues/60)
* preserve trailing whitespace in manifest ([06426ec](06426ec))
* print queued pkg count instead of total ([d893a7f](d893a7f))
* process optional deps during manifest update ([4b7066c](4b7066c))
* provide partial release ([898998a](898998a))
* publish updated deps ([791f55a](791f55a)), closes [#1](#1)
* rm npm from peer deps ([307e505](307e505))
* **sequential-prepare:** do not wait forever when a child package has no change ([713046a](713046a))
* specify used but forgotten dependencies ([73def7f](73def7f))
* sync pkg version after running the npm plugin ([1d24e45](1d24e45))
* trigger next pkg `prepare` after the prev `publish` ([f74d185](f74d185))
* try to prevent deps update rollback ([9108350](9108350))
* up deps, fix some vuls ([2d5cf86](2d5cf86))
* update deps, fix some vuls ([f3cafc8](f3cafc8))
* update manifest version before npm plugin prepare step ([a1ae4c3](a1ae4c3)), closes [qiwi#58](https://github.com/anolilab/multi-semantic-release/issues/58)
* **update-deps:** properly resolve next pre-versions ([62b348e](62b348e))
* wrong context.commits when have multiple releases commit ([f82f125](f82f125))

### Performance Improvements

* deps revision ([4f62817](4f62817))
* log improvements ([c45dccc](c45dccc))
* log multi-sem-rel flags ([75389e0](75389e0))
* log yarn paths ([3896d5c](3896d5c))
* **package:** up deps ([506a0e8](506a0e8))
* **package:** up deps ([6b903a7](6b903a7))
* **package:** up deps & tech release ([bf00b41](bf00b41))
* refactor nextPreVersion to reduce cognitive complexity ([qiwi#35](https://github.com/anolilab/multi-semantic-release/issues/35)) ([601bbd3](601bbd3))
* straighten plugins execution pipeline ([e57fe2f](e57fe2f)), closes [#4](#4)
* up deps ([f9e0c8a](f9e0c8a))
* up deps, minor code improvements ([a7aa625](a7aa625))
* various synchronizer optimizations ([87a7602](87a7602))

### Code Refactoring

* move to ESM ([99fffa9](99fffa9))
prisis pushed a commit to anolilab/multi-semantic-release that referenced this issue Sep 28, 2023
### ⚠ BREAKING CHANGES

* semantic-release/semantic-release@v19.0.5...v21.0.5
* drop support for cycled monorepos
* require Node.js v12
* sequentialPrepare is set to true, to disable pass `--no-sequential-prepare` option
* semrel npm plugin calls local npm version semantic-release/npm#445
* **engine:** the latest semantic-release requires Node.js 10.18
* drop nodejs v8

### Features

* add --tag-version-format flag ([259864c](259864c))
* add debugger ([d2c090d](d2c090d))
* add dependencies updating controller ([0c9b040](0c9b040))
* add execa queued hook ([042933e](042933e))
* add execasync CLI flag to make execa calls be always synchronous ([693438c](693438c)), closes [#1](#1)
* add meow as cli provider ([6de93b9](6de93b9))
* add pnpm and bolt support ([91465de](91465de))
* add process.spawn arg watcher ([7699b6f](7699b6f))
* add sequential-init flag to avoid hypothetical concurrent initialization collisions ([348678e](348678e))
* add some debug messages ([ec792e1](ec792e1))
* added declarative config support ([c98ff10](c98ff10))
* allow to run prepare steps sequentially ([299748a](299748a))
* apply --first-parent filter to commits ([14a896b](14a896b))
* apply queuefy to plugin methods instead of execa ([9ae7d0d](9ae7d0d))
* bump semrel to v19 ([e6b8acb](e6b8acb))
* check that sequentialPrepare is not enabled on cyclic projects ([68c1198](68c1198))
* **debug:** attach pkg prefixes to debug notes ([25e111f](25e111f))
* **debug:** log manifest deps changes ([88b4077](88b4077)), closes [qiwi#27](https://github.com/anolilab/multi-semantic-release/issues/27)
* **debug:** print passed cli flags ([d720cd7](d720cd7))
* drop nodejs v8 support ([80f0a24](80f0a24))
* enable `sequentialPrepare` flag by default ([ad7e81f](ad7e81f))
* enable first-parent commits filtering by cli flag ([33306cc](33306cc))
* **engine:** up nodejs version ([10af385](10af385))
* handle .cjs configs ([38f657a](38f657a))
* ignore packages to be released with workspaces and CLI ([qiwi#42](https://github.com/anolilab/multi-semantic-release/issues/42)) ([b98e181](b98e181))
* Initial commit ([942ef94](942ef94))
* introduce `deps.prefix` flag to inject carets ([c3f4529](c3f4529))
* introduce `ignorePrivate` flag ([e4891c9](e4891c9)), closes [qiwi#66](https://github.com/anolilab/multi-semantic-release/issues/66)
* introduce `log-level` config option ([3fb6584](3fb6584))
* introduce a silent mode([qiwi#88](https://github.com/anolilab/multi-semantic-release/issues/88)) ([47a27d8](47a27d8))
* let publish step run in parallel ([4d5c451](4d5c451))
* log filtered commits in debug ([c64b8e1](c64b8e1))
* log manifest path ([db451e8](db451e8))
* new updated version of the multi-semantic-release lib ([8bdc8be](8bdc8be))
* prefer nested CLI flags ([1bf08cc](1bf08cc))
* provide pre-release flow ([6a9ce16](6a9ce16)), closes [qiwi#25](https://github.com/anolilab/multi-semantic-release/issues/25)
* replace synchronizer with @semrel-extra/topo ([ddd1032](ddd1032))
* support `${version}+${name}` tag format ([c53fefb](c53fefb)), closes [qiwi#71](https://github.com/anolilab/multi-semantic-release/issues/71)
* support `release.config.cjs` ([a6b9370](a6b9370))
* support workspace.packages notation ([4a606b2](4a606b2))
* tech release ([828a82d](828a82d))
* update semver from v19 to v21 ([6e4c378](6e4c378))
* uphold the prev package.json indents ([ac5832f](ac5832f))

### Bug Fixes

* add flag to enable sequentialPrepare mode ([70c2dc5](70c2dc5))
* add sync point for publish step ([adc823e](adc823e))
* added missing publishConfig ([f00ea9a](f00ea9a))
* allow any `todo` package to run the `generateNotes` queue ([26a87d7](26a87d7)), closes [#9](#9)
* apply deps update before npm's plugin prepare ([77b6ee2](77b6ee2))
* avoid non-updated local dependencies bump ([qiwi#33](https://github.com/anolilab/multi-semantic-release/issues/33)) ([9faeef6](9faeef6))
* beautify log labels ([78cbc8a](78cbc8a))
* bump-up of pre-version  ([02ef270](02ef270))
* **cli:** fix inner spawnhook call ([70aa292](70aa292))
* **cli:** restore watchspawn context ([56145aa](56145aa))
* **config:** fix `options` and `plugins` resolver ([56e974c](56e974c))
* correct global config use ([8e5fb99](8e5fb99))
* dont fetch tags if tags arg is empty array ([3a79558](3a79558))
* ensure msr cli flags take precedence over their semrel equivalents ([2be75fa](2be75fa))
* filter only tags that are valid ([59b61ad](59b61ad))
* filter queued packages on generateNotes stage ([e0625ce](e0625ce)), closes [#6](#6)
* fix cascade bumping when some dep belongs to several levels of the dep tree ([cf20dea](cf20dea))
* fix debug logging ([71527b2](71527b2))
* fix export point ([cf31425](cf31425))
* fix getNextVersion resolver ([7275ae7](7275ae7))
* fix globbing on Windows ([qiwi#57](https://github.com/anolilab/multi-semantic-release/issues/57)) ([1d71d21](1d71d21))
* fix internal flag ref filterParent → firstParent ([8c7400f](8c7400f))
* fix logger path ([232d2dc](232d2dc))
* fix nextType resolver ([606914b](606914b))
* fix pkgOptions resolver ([2a2f0cf](2a2f0cf))
* force a release ([1e3ece5](1e3ece5))
* getVersionFromTag tests to fix release process ([e7f1646](e7f1646))
* local dependencies correct bump from release to prerelease ([qiwi#34](https://github.com/anolilab/multi-semantic-release/issues/34)) ([6481a59](6481a59))
* make logger to be singleton ([1790794](1790794))
* missing @ in tagFormat ([3faa0f1](3faa0f1))
* more robust stream rescoping (to fix bug in npm module) ([34c7c62](34c7c62))
* override env.TRAVIS_PULL_REQUEST_BRANCH to fix PR checks on travis-ci ([e4b1929](e4b1929)), closes [#11](#11)
* **package:** add missed sem-rel plugins ([f3c9318](f3c9318))
* **package:** up deps, fix some vuls ([d8905b0](d8905b0))
* **package:** up deps, fix vulns ([5a4d91e](5a4d91e))
* **package:** update execa to be compatible with sem-rel 15.13.28 ([069bb4e](069bb4e)), closes [#7](#7)
* pass stderr and stdout into semantic's getConfig (bug in npm) ([cf596cb](cf596cb))
* pin npm as peer dep ([67d8b80](67d8b80))
* pin npm version to v8.4.1 ([22c89d1](22c89d1)), closes [qiwi#60](https://github.com/anolilab/multi-semantic-release/issues/60)
* preserve trailing whitespace in manifest ([06426ec](06426ec))
* print queued pkg count instead of total ([d893a7f](d893a7f))
* process optional deps during manifest update ([4b7066c](4b7066c))
* provide partial release ([898998a](898998a))
* publish updated deps ([791f55a](791f55a)), closes [#1](#1)
* rm npm from peer deps ([307e505](307e505))
* **sequential-prepare:** do not wait forever when a child package has no change ([713046a](713046a))
* specify used but forgotten dependencies ([73def7f](73def7f))
* sync pkg version after running the npm plugin ([1d24e45](1d24e45))
* trigger next pkg `prepare` after the prev `publish` ([f74d185](f74d185))
* try to prevent deps update rollback ([9108350](9108350))
* up deps, fix some vuls ([2d5cf86](2d5cf86))
* update deps, fix some vuls ([f3cafc8](f3cafc8))
* update manifest version before npm plugin prepare step ([a1ae4c3](a1ae4c3)), closes [qiwi#58](https://github.com/anolilab/multi-semantic-release/issues/58)
* **update-deps:** properly resolve next pre-versions ([62b348e](62b348e))
* wrong context.commits when have multiple releases commit ([f82f125](f82f125))

### Performance Improvements

* deps revision ([4f62817](4f62817))
* log improvements ([c45dccc](c45dccc))
* log multi-sem-rel flags ([75389e0](75389e0))
* log yarn paths ([3896d5c](3896d5c))
* **package:** up deps ([506a0e8](506a0e8))
* **package:** up deps ([6b903a7](6b903a7))
* **package:** up deps & tech release ([bf00b41](bf00b41))
* refactor nextPreVersion to reduce cognitive complexity ([qiwi#35](https://github.com/anolilab/multi-semantic-release/issues/35)) ([601bbd3](601bbd3))
* straighten plugins execution pipeline ([e57fe2f](e57fe2f)), closes [#4](#4)
* up deps ([f9e0c8a](f9e0c8a))
* up deps, minor code improvements ([a7aa625](a7aa625))
* various synchronizer optimizations ([87a7602](87a7602))

### Code Refactoring

* move to ESM ([99fffa9](99fffa9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants