Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve test reliability of test
test_plugin_hdfs_add
by cleaning state pollution insi_app
by deleting data source and clearingdata_source_dict
The test can fail in this way by running
pip3 install pytest-repeat; python3 -m pytest --count=2 test/test_plugin_mysql_hdfs.py::test_plugin_hdfs_add
:Such failure occurs while running on
test_plugin_mysql_add
, and can be fixed in the same way.It may be better to clean state pollutions so that some other tests won't fail in the future due to the shared state pollution.