Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse Lexicon Bug - on LexiconConfigService - LEX_DATA is completely updated, even for a single lexicon change. #33

Open
xrhstosdion opened this issue Oct 20, 2022 · 0 comments

Comments

@xrhstosdion
Copy link

On LexiconConfigService method:

private void updateKeys(List<Map<String, Object>> translations, String groupId, String languageId) {

There is a bug on the following check:

else if (keyDTO.getTranslations().get(languageId) == null || ((String)keyDTO.getTranslations().get(languageId)).equals(translationKey) || translation.get("forceUpdate") != null && Boolean.TRUE.equals(translation.get("forceUpdate"))) { this.keyService.updateTranslation(keyDTO.getId(), languageId, translationValue); }

keyDTO.getTranslations().get(languageId) Problem is the languageId is the UUID of the language, while instead the translations map holds the locale (de, en, etc) as key.

The result is for the check to always return true and proceed to update every single entry of LEX_DATA, even for a single lexicon change.

xrhstosdion pushed a commit that referenced this issue Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant