Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pov status rpc #39

Merged
merged 1 commit into from
Dec 18, 2019
Merged

feat: add pov status rpc #39

merged 1 commit into from
Dec 18, 2019

Conversation

harlanasimov
Copy link

Proposed changes in this pull request

add pov status rpc

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

Write a small comment explaining if its N/A (not applicable)

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

@harlanasimov harlanasimov added this to the v1.3.x milestone Dec 18, 2019
@harlanasimov harlanasimov self-assigned this Dec 18, 2019
@harlanasimov harlanasimov added this to In progress in QLC Chain via automation Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #39 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #39      +/-   ##
=========================================
- Coverage    7.66%   7.66%   -0.01%     
=========================================
  Files          61      61              
  Lines        9807    9813       +6     
=========================================
  Hits          752     752              
- Misses       8993    8999       +6     
  Partials       62      62
Flag Coverage Δ
#unittests 7.66% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pov.go 1.1% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2297cc6...89cf35d. Read the comment docs.

@@ -15,6 +15,12 @@ type PovApi struct {
client *rpc.Client
}

type PovApiStatus struct {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type PovApiStatus should be PovAPIStatus (from golint)

@mergify mergify bot merged commit 976ce49 into master Dec 18, 2019
QLC Chain automation moved this from In progress to Done Dec 18, 2019
@mergify mergify bot deleted the feature/pov-status branch December 18, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
QLC Chain
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants