[QOL-9199] migrate from amazee.io test containers to OKFN #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
requested review from
duttonw,
devonpis,
kundupz,
asifaminb,
chris-randall-qol and
RossWebsterWork
duttonw
approved these changes
Aug 15, 2022
|
|
||
| ENV DOCKERIZE_VERSION v0.6.1 | ||
| RUN apk add --no-cache build-base \ | ||
| && curl -sLO https://github.com/jwilder/dockerize/releases/download/${DOCKERIZE_VERSION}/dockerize-alpine-linux-amd64-${DOCKERIZE_VERSION}.tar.gz \ |
There was a problem hiding this comment.
if you could include the dockerize version in git it may go even faster.
There was a problem hiding this comment.
Actually, I don't think we use dockerize for anything except a socket test that could be done with preinstalled netcat.
|
|
||
| name: Continuous Integration build on CKAN ${{ matrix.ckan-version }} ${{ matrix.python-version }} | ||
| name: Continuous Integration build on CKAN ${{ matrix.ckan-version }} | ||
| runs-on: ubuntu-latest | ||
| container: integratedexperts/ci-builder |
There was a problem hiding this comment.
You could investigate adding container caching to our github actions list to see if that makes it even faster (for base) https://github.com/marketplace/actions/docker-layer-caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should result in faster builds, easier updates (since OKFN has already done the work of preinstalling the right dependency versions), and better compatibility with other forks (which will normally use OKFN containers).