Develop to master - handle 'delete all' without JavaScript #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Similar functionality is provided by core for deleting packages
…e data requests - Pre-CKAN 2.10 seems to have issues, and we don't really need the dialog
…eation [QOLDEV-638] add support for non-JavaScript delete-all page
ThrawnCA
requested review from
duttonw,
kundupz,
chris-randall-qol and
RossWebsterWork
duttonw
approved these changes
Oct 26, 2023
- Replace deprecated log function name - Use 'assert' keyword instead of calling unittest.assertEquals - Fix typos - Fix 'When' vs 'Then' usage in scenario test
- Optionally send notification email when data request is updated - Allow configuration of emailing all org members vs just admins
…eation QOLDEV-638 sync features with ckanext-data-qld
duttonw
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a confirmation page instead of the 'confirm-action' JavaScript module, for more consistent and reliable behaviour.