Develop to master - sync with upstream #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add CKAN 2.10 compatibility - move plugin module to top level so it has a distinctive module name and simpler paths - move controller and CLI modules to better match upstream names - use ckan_cli to unify test steps
- Usually we don't need the second value, but it has to at least be None
- Flask automatically converts query string parameters into routing arguments, so we need to take into account the possibility of having an organisation supplied despite not being on an org URL
- To generate the query properly, we need to use '== None' rather than 'is None'
- pass the function, not the result of it
- don't assume that a newly added dataset will appear in the report when we haven't refreshed it
- Explicitly define index route so Py3 is happy - Add formatting so breadcrumbs are pretty
- Only run on pull request if targeting master, otherwise 'push' is enough
- supply the organisation any time the report wants one, not based on whether one was passed in
- drop unnecessary 'list' calls - extract CLI logic into private helper functions
QOL-9161 sync from upstream and fix bugs
[QOL-9055] add Behave-based scenario testing
ThrawnCA
requested review from
asifaminb,
chris-randall-qol,
devonpis,
duttonw,
kundupz and
RossWebsterWork
duttonw
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.