Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qol 9130 sso demo improvement #87

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Conversation

devonpis
Copy link
Contributor

  • explore any other alternative for the logout action
    • only popup approavh is available due to security settings in the logout page header
  • improve the popup logout approach, by checking logout action is completly finished
  • improve loading indicator
  • add story for direct access to the actual form

more changes to the form in https://api.forms.platforms.qld.gov.au/#/project/612eeb800db6b412a3f37e1f/form/62564e89bbc38d840d92b664/edit

  • extract reusable variables as individual data properties
  • fix the way to get namespace
  • fix the condition to show/hide submit button and message
  • add condition to prevent access the form directly (display warning message)

@devonpis devonpis requested a review from a team July 26, 2022 01:22
@devonpis devonpis merged commit 3750f1e into main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants