QOL-8396 add GA data attr to image #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manjeetkgov
approved these changes
Mar 1, 2022
devonpis
added a commit
that referenced
this pull request
Mar 3, 2022
* QOL-7764 Add disabled state to default and themed radio buttons / checkboxes (#374) * QOL-7764 disabled state added to default and themed radio buttons and checkboxes * QOL-7764 Changed some colours to use variables * QOL-7980 Transfer qg print from Matrix Assets to SWE4 (#376) * QOL-7980 Transfer qg print from Matrix Assets to SWE4 * updated FAQ * Added description and example markup for tables (#373) * QOL-8453 Update SWE FontAwesome <i> to <span> tags (#391) * QOL-8453 updated all fontawesome icon instances to use the sematically correct span tag, instead of i * QOL-8453 fixed find and replace error * updated readme * updated readme * updated readme * Qol 8391 form io style in swe (#393) * added forms.io styles * added forms.io styles * removed redundant versions * DC-26939-hashTrigger-function-fix (#379) * DC-26939-hashTrigger-function-fix * Added accordion-test.js * Added accordion-test.js * headless false * updated test * Qol 8453 reinstate back compatibility (#394) * reinstate style for fa using i and add warning * update msg * Dc 26939 accordion hashtrigger ix (#395) * DC-26939-hashTrigger-function-fix * Added accordion-test.js * Added accordion-test.js * headless false * updated test * added id match as well * added id match as well * check to run only one hash check (#396) * check to run only one hash check * removed console log * Qol 8453 add tests on alert and call out box (#399) * fix warning on vscode eslint plugin * add tests and stories in doc * nowrap any telephone numbers (#398) * Qol 8453 add tests on alert and call out box (#400) * fix warning on vscode eslint plugin * add tests and stories in doc * update qg-misc * update setTimeout * add comment * update timeout * update timeout * update test * DC-28049 Community Support Franchise (https://www.qld.gov.au/communit… (#401) * DC-28049 Community Support Franchise (https://www.qld.gov.au/community) broken hyperlink * transferred to 'head assets template' * Updated doc (#402) * Updated doc * Updated doc * QOL-8448 Updated facebook SDK version * transferred forms.io styles migration to the next release * DC-26939 - hashTrigger function fix and added test * QOL-7980 - Transfer qg print from Matrix Assets to SWE4 * QOL-8446 Update broken link in SWE template * QOL-7980-Transfer qg print from Matrix Assets to SWE4 * featured box link colour fix * release-v4.0.11-Hotfix * added timeout in 'quick exit test' * Qol 8396 UI design for image zoom on click for swe 4 (#410) * QOL-8396 UI design for Image zoom on click for SWE 4 * QOL-8396 UI design for Image zoom on click for SWE 4 and DC-28049 - change AGLS links * floating images * Added comments and styles changes * Added comments and styles changes * default color styles * refactor image figure Co-authored-by: asifamingov <asif.amin@dsiti.qld.gov.au> * rename class for backward compatibility (#412) * Dc 96239 hash on links (#403) * check to run only one hash check * removed console log * updated function * updated function * update style (#426) * fix qg-location (#427) * QOL-8396 fix style bug (#428) * fix style * update figure max-width * add ga data attr to image (#429) Co-authored-by: Rebecca Launder <950889+re-becca@users.noreply.github.com> Co-authored-by: Asif Amin <30643973+asifamingov@users.noreply.github.com> Co-authored-by: asifamingov <asif.amin@dsiti.qld.gov.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title