Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOLDEV-260 heading line height fix #750

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

re-becca
Copy link
Member

@re-becca re-becca commented Feb 1, 2023

Current heading line-heights are based on the imported Bootstrap (3-ish) styles where default is 1.1 (unitless), except for h2 which has been customised to be 1.5rem.

As a fix to adjust the heading line heights to accommodate new hyperlink styles my pull request proposes to:

  • Increase default line-height of headings to 1.3 (this will then apply to h1 and h2)
  • Increase line-height of h3 and h4 to 1.4
  • Increase line-height of h5 and h6 to 1.5

@re-becca re-becca merged commit 435d694 into release-v4.1.0 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants