Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QOLDEV-328 Improving landmarks for a11y #850

Merged
merged 2 commits into from
Mar 28, 2023
Merged

QOLDEV-328 Improving landmarks for a11y #850

merged 2 commits into from
Mar 28, 2023

Conversation

ghazal-salehi
Copy link
Contributor

https://ssq-qol.atlassian.net/browse/QOLDEV-328

Changes required to the landmarks:

  • Adding role=”banner” to tag
  • Updating aria-label=”Main navigation” to aria-label=”main” as it would read as 'Main navigation navigation' by screen readers. (id="qg-site-nav")
  • Adding aria-label=”top” to the tag (id="qg-portal-links")
  • Removing role='navigation' from Skip to main (id="qg-access")

@ghazal-salehi ghazal-salehi self-assigned this Mar 24, 2023
@ghazal-salehi ghazal-salehi merged commit 824a9c2 into release-v4.2.0 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossWebsterWork RossWebsterWork RossWebsterWork approved these changes

@chris-randall-qol chris-randall-qol Awaiting requested review from chris-randall-qol

@duttonw duttonw Awaiting requested review from duttonw

@kundupz kundupz Awaiting requested review from kundupz

@ThrawnCA ThrawnCA Awaiting requested review from ThrawnCA

@stvp-qld stvp-qld Awaiting requested review from stvp-qld

Assignees

@ghazal-salehi ghazal-salehi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ghazal-salehi @RossWebsterWork