fix(node): exclude test patterns in coverage

qlik-oss · Mar 18, 2019 · 306e45d · 306e45d
1 parent f976e15
commit 306e45d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/commands/node/src/index.js b/commands/node/src/index.js
@@ -218,7 +218,7 @@ class Runner extends EventEmitter {
       this.logLine('Loading', file);
     });
     this.nyc = new NYC(this.argv.nyc);
-    this.argv.shouldInstrument = f => this.nyc.exclude.shouldInstrument(f);
+    this.argv.shouldInstrument = f => !utils.isTestFile(f, this.argv) && this.nyc.exclude.shouldInstrument(f);
     try {
       this.deleteCoverage()
         .setup(testFiles, srcFiles)

diff --git a/packages/utils/src/index.js b/packages/utils/src/index.js
@@ -69,6 +69,8 @@ const DEFAULT_TRANSFORM_EXCLUDE_PATTERN = [
   '**/*require*.js',
   '**/*sinon*.js',
   '**/*chai*.js',
+  DEFAULT_TEST_EXT_PATTERN,
+  DEFAULT_TEST_GLOB_PATTERN,
 ];
 const DEFAULT_INSTRUMENT_EXCLUDE_PATTERN = DEFAULT_TRANSFORM_EXCLUDE_PATTERN;