Adding possibility to use external chrome #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoffeastrom
suggested changes
Nov 7, 2018
There was a problem hiding this comment.
I think we should move this under chrome so we are consistent. Since the https://github.com/GoogleChrome/puppeteer/blob/v1.10.0/docs/api.md#puppeteerconnectoptions
has more options you might want to pass them also.
Add a launch flag instead that is true default
So if you pass --no-launch it will connect instead and pass the this.argv.chrome
|
Updated after review - thanks @stoffeastrom |
stoffeastrom
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.