Fixes issue with jumpy column width (#184)

Fixes #182 Did not implement "ellipis in the middle of the field name", since there was no easy solution to this. Should be a separate issue.
qlik-oss · Feb 18, 2019 · f76d0a1 · f76d0a1
1 parent e5eae5e
commit f76d0a1
Show file tree

Hide file tree

Showing 10 changed files with 9 additions and 1 deletion.
diff --git a/src/components/model.pcss b/src/components/model.pcss
@@ -26,6 +26,8 @@
     height: 5em;
     justify-content: center;
     min-height: 5em;
+    text-align: center;
+    word-break: break-word;
 
     .nbr-of-rows {
       font-weight: 400;
@@ -182,6 +184,7 @@
 
     .column {
       box-sizing: border-box;
+      max-width: 48rem;
       padding: 3.5em;
     }
 

diff --git a/src/components/table-field.pcss b/src/components/table-field.pcss
@@ -12,6 +12,12 @@
   padding: 1em;
   position: relative;
 
+  .name,
+  .bartext {
+    margin-right: 1em;
+    padding: 0 0.5em;
+  }
+
   &:hover {
     box-shadow: 0 0 2em -0.5em #999;
   }
@@ -36,7 +42,6 @@
     .name {
       background-color: #019b39;
       color: white;
-      padding: 0 0.5em;
     }
   }
 

diff --git a/test/e2e/__artifacts__/baseline/cleared-selections.png b/test/e2e/__artifacts__/baseline/cleared-selections.png
diff --git a/test/e2e/__artifacts__/baseline/created-hypercube.png b/test/e2e/__artifacts__/baseline/created-hypercube.png
diff --git a/test/e2e/__artifacts__/baseline/extra-information-box.png b/test/e2e/__artifacts__/baseline/extra-information-box.png
diff --git a/test/e2e/__artifacts__/baseline/loaded-app.png b/test/e2e/__artifacts__/baseline/loaded-app.png
diff --git a/test/e2e/__artifacts__/baseline/make-another-selection-in-selection-bar.png b/test/e2e/__artifacts__/baseline/make-another-selection-in-selection-bar.png
diff --git a/test/e2e/__artifacts__/baseline/open-hypercube-view.png b/test/e2e/__artifacts__/baseline/open-hypercube-view.png
diff --git a/test/e2e/__artifacts__/baseline/opened-menu.png b/test/e2e/__artifacts__/baseline/opened-menu.png
diff --git a/test/e2e/__artifacts__/baseline/selection.png b/test/e2e/__artifacts__/baseline/selection.png