Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Adding a guide that is run the first time a user enters catwalk. #142

Merged
merged 7 commits into from Jan 23, 2019

Conversation

hrigner
Copy link

@hrigner hrigner commented Jan 21, 2019

Closes #16

@netlify
Copy link

netlify bot commented Jan 21, 2019

Deploy preview for catwalk-qlikcore ready!

Built with commit e76ff52

https://deploy-preview-142--catwalk-qlikcore.netlify.com

@sublibra
Copy link
Contributor

Looks very good overall!

Step 2:
Need a stronger wrap on the URL?
image

Step 3:
Picky picky.. rounded corner and arrow so close seems like a visual bug to me.
image

If you open an app without data the flow is broken and you are thrown to hypercubebuilder step after step 2. The guide breaks after this.

@sublibra sublibra closed this Jan 22, 2019
@sublibra sublibra reopened this Jan 22, 2019
@sublibra
Copy link
Contributor

Sorry SBS

@peol
Copy link
Contributor

peol commented Jan 22, 2019

@sublibra Usually people use <input> elements to wrap long links that should be easy to copy/paste.

Copy link
Contributor

@peol peol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall! I think we should go with catwalk (lowercase) everywhere to be consistent. Saw a couple of places in the tutorial text which was inconsistent :)

The guide bugs out for me a few times

  • the highlight area didn't update to cover the full listbox
  • maybe we shouldn't automatically continue when selecting one value, it was hard to understand what happened when the guide just went to the next step
  • hypercube guide is covered by the cookie consent notification bar

<p>
where
{' '}
<i>engine_url</i>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use <code> instead of <i> for these.

The field name and the number of field values are visible.
</p>
<p>
The number of field values are presented in the form of 6 of 6(5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section reads a bit weird for me, shouldn't the full form be presented first before talking about parts of it? I.e. explain 6(5) before explaining 6. I also got a bit confused when the numbers weren't related to my app/the focused field :)

@hrigner hrigner merged commit 785ee87 into master Jan 23, 2019
@axelssonHakan axelssonHakan deleted the tutorial branch January 23, 2019 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants