-
Notifications
You must be signed in to change notification settings - Fork 12
Adding a guide that is run the first time a user enters catwalk. #142
Conversation
Deploy preview for catwalk-qlikcore ready! Built with commit e76ff52 |
Sorry SBS |
@sublibra Usually people use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall! I think we should go with catwalk
(lowercase) everywhere to be consistent. Saw a couple of places in the tutorial text which was inconsistent :)
The guide bugs out for me a few times
- the highlight area didn't update to cover the full listbox
- maybe we shouldn't automatically continue when selecting one value, it was hard to understand what happened when the guide just went to the next step
- hypercube guide is covered by the cookie consent notification bar
src/components/guide-steps.jsx
Outdated
<p> | ||
where | ||
{' '} | ||
<i>engine_url</i> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use <code>
instead of <i>
for these.
src/components/guide-steps.jsx
Outdated
The field name and the number of field values are visible. | ||
</p> | ||
<p> | ||
The number of field values are presented in the form of 6 of 6(5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section reads a bit weird for me, shouldn't the full form be presented first before talking about parts of it? I.e. explain 6(5)
before explaining 6
. I also got a bit confused when the numbers weren't related to my app/the focused field :)
Closes #16