Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Sense info #170

Merged
merged 6 commits into from Feb 5, 2019
Merged

Sense info #170

merged 6 commits into from Feb 5, 2019

Conversation

axelssonHakan
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Feb 5, 2019

Deploy preview for catwalk-qlikcore ready!

Built with commit c51ab34

https://deploy-preview-170--catwalk-qlikcore.netlify.com

```bash
ACCEPT_EULA=yes/no docker-compose up -d
npm install
npm start
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm start -> npm run start?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both works

README.md Outdated

### Example App
For convenience the is an example app and docker-compose.yml in the catwalk repository
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the -> there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

README.md Outdated

![host white list](./images/qmc-whitelist.png)

### Tips :tada:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only have one tip, so use ###Tip .
Or make it a bullet list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

Copy link
Member

@wennmo wennmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just minor comments

README.md Outdated

You may also attach to an existing engine session (make sure that you have already created a session using the same websocket URL + user):
## 2. Qlik Associative Engine
You need to provide catwalk with a WS-URL (web socket URL) to the app.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe its just enough to type websocket URL and skip the WS-URL...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated
npm install
npm start
```
Or through the Qlik hosted [catwalk UI](https://catwalk.core.qlik.com)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this bullet be described further e.g. that it only serves the UI and can be used to access an local engine?

README.md Outdated
`ws://localhost:9076/data/drugcases.qvf`

### Qlik Sense Desktop
For connecting to a Qlik Sense Desktop the WS-URL will be:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to websocket URL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@hrigner hrigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sublibra sublibra self-requested a review February 5, 2019 07:51
@axelssonHakan axelssonHakan merged commit 6150731 into master Feb 5, 2019
@axelssonHakan axelssonHakan deleted the senseInfo branch February 5, 2019 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants