Conversation
Deploy preview for catwalk-qlikcore ready! Built with commit c51ab34 |
```bash | ||
ACCEPT_EULA=yes/no docker-compose up -d | ||
npm install | ||
npm start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm start -> npm run start?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both works
README.md
Outdated
|
||
### Example App | ||
For convenience the is an example app and docker-compose.yml in the catwalk repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the -> there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
README.md
Outdated
|
||
![host white list](./images/qmc-whitelist.png) | ||
|
||
### Tips :tada: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only have one tip, so use ###Tip .
Or make it a bullet list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just minor comments
README.md
Outdated
|
||
You may also attach to an existing engine session (make sure that you have already created a session using the same websocket URL + user): | ||
## 2. Qlik Associative Engine | ||
You need to provide catwalk with a WS-URL (web socket URL) to the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe its just enough to type websocket URL and skip the WS-URL...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
README.md
Outdated
npm install | ||
npm start | ||
``` | ||
Or through the Qlik hosted [catwalk UI](https://catwalk.core.qlik.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this bullet be described further e.g. that it only serves the UI and can be used to access an local engine?
README.md
Outdated
`ws://localhost:9076/data/drugcases.qvf` | ||
|
||
### Qlik Sense Desktop | ||
For connecting to a Qlik Sense Desktop the WS-URL will be: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to websocket URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.