This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Storing hypercubes in localstorage #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for catwalk-qlikcore ready! Built with commit 64b7b0c |
hrigner
changed the title
peol
reviewed
Apr 19, 2019
src/components/cube.jsx
Outdated
| @@ -28,6 +32,41 @@ const Cube = forwardRef(({ app, tableData: { initialColumns }, closeOnClickOutsi | |||
| let model = null; | |||
| let hypercubeProps = null; | |||
|
|
|||
| const modifyLocalStorage = (action) => { | |||
There was a problem hiding this comment.
Perhaps use something like https://github.com/rehooks/local-storage ?
There was a problem hiding this comment.
I don't want to constantly read/write to localstorage (to keep sync with some kind of state). Otherwise it's just replacing one line with another line and also adding a new dependency.
src/components/cubes.jsx
Outdated
| @@ -42,6 +48,22 @@ export function Cubes({ app, closeOnClickOutside }) { | |||
| forceUpdate(); | |||
| } | |||
|
|
|||
| useEffect(() => { | |||
| // Check if cubes are stored in localstorage. | |||
| let storedCubes = localStorage.getItem(app.id); | |||
There was a problem hiding this comment.
I believe this can throw an error if local storage is disabled, we probably need to gracefully disable this feature if we cannot use LS.
There was a problem hiding this comment.
Good catch. I added a check if localstorage is disabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237