This repository has been archived by the owner on Oct 12, 2020. It is now read-only.
change to CreateApp from CreateDocEx #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredrikFolkesson
commented
Dec 3, 2018
access/access_test.go
Outdated
| @@ -134,15 +134,17 @@ func TestAccessReloadEngine(t *testing.T) { | |||
|
|
|||
| // testCanCreateApp verifies that the current user can create an app. | |||
| func testCanCreateApp(t *testing.T) { | |||
| testState.app, err = createApp(testState.global, appName) | |||
| success := false | |||
There was a problem hiding this comment.
I have to create the variable before using it here since := cant be used when saving to a field.
(for testState.appID)
peol
reviewed
Dec 3, 2018
access/access.go
Outdated
| func createApp(global *enigma.Global, appName string) (*enigma.Doc, error) { | ||
| return global.CreateDocEx(ctx, appName, "", "", "", "Main") | ||
| func createApp(global *enigma.Global, appName string) (bool, string, error) { | ||
| return global.CreateApp(ctx, appName, "Main") |
There was a problem hiding this comment.
Couldn't you store appId here and return global.OpenDoc(appId) and have rest of the code as it was?
There was a problem hiding this comment.
Yeah that makes a lot more sense :)
FredrikFolkesson
force-pushed
the
change-to-createApp
branch
from
b87b059
to
23c274c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from
CreateDocExtoCreateAppsinceCreateDocExis only supposed to work in desktop mode and withABACengine runs inScalablemode.Had to make some other minor changes since
CreateAppdoes not return thedocobject asCreateDocExdoes.