Adding Volumes, and Readme updated #16

carlioth · 2018-04-05T06:50:50Z

Volumes fixed
Created scripts to make it easier for the documentation
Documentation big re-write

Fixes #25, fixes #20

gabbaxx

Looks good!

peol

LGTM, but there's a lot of information here that is non-technical/more about following commands like in a tutorial—should probably reduce that info in this repo and move it over to the documentation repo in the future instead.

FredrikFolkesson · 2018-04-05T12:07:19Z

@peol basically all of this documentation should be moved to the documentation repo I think, since it as you say is how you use this demo/example and not how you would continue to develop on it

FredrikFolkesson

LGTM,

Some small comments.

Chown must happen after seeding with the app though, otherwise it wont change owner to the nobody user

FredrikFolkesson · 2018-04-05T12:12:06Z

README.md

+
+After the script finished you should be able to query the Kubernetes cluster. To see some metric execute the following commands: 
+
+Node metrics:

 ```bash
 kubectl get --raw "/apis/metrics.k8s.io/v1beta1/nodes" | jq .


Add a note that you need jq?

FredrikFolkesson · 2018-04-05T12:16:42Z

settings.config

@@ -0,0 +1,11 @@
+GCLOUD_PROJECT="${GCLOUD_PROJECT}"


GCLOUD_PROJECT="${GCLOUD_PROJECT:-your-project-name-here}"

FredrikFolkesson · 2018-04-05T12:18:45Z

README.md

+### Option 2 - Setting up Custom Metrics Server step by step
+
+Now we can scale on the built-in metrics which is CPU and Memory, but in order to scale based on custom metrics you need to have two components. 
+One component that collects metrics from your applications and stores them the [Prometheus](https://prometheus.io) in a time series database.


... and stores them USING? Prometheus...

FredrikFolkesson · 2018-04-05T12:40:07Z

README.md

@@ -42,7 +65,7 @@ Take the output of the above command and increase priveleges:
 kubectl create clusterrolebinding myname-cluster-admin-binding --clusterrole=cluster-admin --user=<ACCOUNT FROM ABOVE>


Maybe add a note that sometimes the case does not match. I.E

gcloud info | grep Account gives me fredrik.folkesson... but the actual user is Fredrik.Folkesson... and the rolebinding must thus match that.

FredrikFolkesson · 2018-04-05T12:43:48Z

README.md

@@ -96,24 +121,27 @@ Get the total qix_active_sessions from the custom metrics API:
 kubectl get --raw "/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/qix_active_sessions" | jq .


add a note that this will give 404 for some time (15-30 seconds) before the metrics are up an running

FredrikFolkesson · 2018-04-05T12:44:33Z

README.md

@@ -96,24 +121,27 @@ Get the total qix_active_sessions from the custom metrics API:
 kubectl get --raw "/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/qix_active_sessions" | jq .
 ```

-Check that the Horizontal Pod Autoscaler is active and check that you have 0 sessions on your engines.
+Check that the HPA (Horizontal Pod Autoscaler), which is responsible for the scaling, is active and check that you have 0 sessions on your engines.


maybe add that this will be <unknown> / 10 for a while before the hpa gets metrics for the first time

FredrikFolkesson · 2018-04-05T13:09:26Z

README.md


 ```bash
-kubectl create -f ./ingress
+./doc-seed.sh


the seeding must happen before the engine starts since the engine extra container does the chowning at start up

FredrikFolkesson · 2018-04-05T14:31:13Z

For me the .qvf file is corrupted, tried downloading it again and same error (Engine fails loading it complaining that the file is corrupted) tried with the drugcases.qvf and it worked. Someone else should probably do the whole tutorial to see if the error is with my computer somehow or the qvf

peol · 2018-04-05T14:34:16Z

@FredrikFolkesson Probably line endings... LF/CRLF, .qvf needs to be added as binary in .gitattributes before qvf is added in a commit.

FredrikFolkesson · 2018-04-05T14:44:19Z

@peol tried taking it from an internal repo and using the file from there, same problem O.o

EDIT: when taking the old one I had from my disc it worked..

…o volumes

…otherwise engine wont own the app (#24)

FredrikFolkesson

LGTM! Great work!

carlioth added 11 commits March 29, 2018 12:08

Scripts to create and delete cluster

95bd516

Adding volume nfs deploy, and engine mounting it

29470d5

Adding app, and seed script to add app to volume

08342ea

Savepoint for readme

55b97ea

Not expose mira

76c27d6

Move nfs volume to Qlik Core folder

0de2d04

Update to scripts

dc6e30b

remove unused ingress

a16a2ad

change name of clusterrole

84f92b6

Update to readme

be9c98d

Missing seeding with apps

a5fa06d

carlioth requested review from gabbaxx and FredrikFolkesson April 5, 2018 06:50

Update names and permission fix

a1bff55

gabbaxx approved these changes Apr 5, 2018

View reviewed changes

peol approved these changes Apr 5, 2018

View reviewed changes

Clearification in readme

5eaae6d

FredrikFolkesson approved these changes Apr 5, 2018

View reviewed changes

Fredrik Folkesson and others added 4 commits April 5, 2018 16:49

non corrupted qvf

1b3f605

Merge branch 'volumes' of https://github.com/qlik-ea/core-scaling int…

accfc30

…o volumes

broke out the nfs parts so they are made before starting the engine, …

36f47e1

…otherwise engine wont own the app (#24)

Update to readme.

08c22e1

FredrikFolkesson approved these changes Apr 10, 2018

View reviewed changes

carlioth merged commit c887dcc into master Apr 10, 2018

FredrikFolkesson deleted the volumes branch May 28, 2018 11:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Volumes, and Readme updated #16

Adding Volumes, and Readme updated #16

carlioth commented Apr 5, 2018 •

edited

gabbaxx left a comment

peol left a comment

FredrikFolkesson commented Apr 5, 2018

FredrikFolkesson left a comment

FredrikFolkesson Apr 5, 2018

FredrikFolkesson Apr 5, 2018

FredrikFolkesson Apr 5, 2018

FredrikFolkesson Apr 5, 2018

FredrikFolkesson Apr 5, 2018

FredrikFolkesson Apr 5, 2018

FredrikFolkesson Apr 5, 2018

FredrikFolkesson commented Apr 5, 2018

peol commented Apr 5, 2018

FredrikFolkesson commented Apr 5, 2018 •

edited by peol

FredrikFolkesson left a comment

		@@ -42,7 +65,7 @@ Take the output of the above command and increase priveleges:
		kubectl create clusterrolebinding myname-cluster-admin-binding --clusterrole=cluster-admin --user=<ACCOUNT FROM ABOVE>

		@@ -96,24 +121,27 @@ Get the total qix_active_sessions from the custom metrics API:
		kubectl get --raw "/apis/custom.metrics.k8s.io/v1beta1/namespaces/default/pods/*/qix_active_sessions" \| jq .

Adding Volumes, and Readme updated #16

Adding Volumes, and Readme updated #16

Conversation

carlioth commented Apr 5, 2018 • edited

gabbaxx left a comment

Choose a reason for hiding this comment

peol left a comment

Choose a reason for hiding this comment

FredrikFolkesson commented Apr 5, 2018

FredrikFolkesson left a comment

Choose a reason for hiding this comment

FredrikFolkesson Apr 5, 2018

Choose a reason for hiding this comment

FredrikFolkesson Apr 5, 2018

Choose a reason for hiding this comment

FredrikFolkesson Apr 5, 2018

Choose a reason for hiding this comment

FredrikFolkesson Apr 5, 2018

Choose a reason for hiding this comment

FredrikFolkesson Apr 5, 2018

Choose a reason for hiding this comment

FredrikFolkesson Apr 5, 2018

Choose a reason for hiding this comment

FredrikFolkesson Apr 5, 2018

Choose a reason for hiding this comment

FredrikFolkesson commented Apr 5, 2018

peol commented Apr 5, 2018

FredrikFolkesson commented Apr 5, 2018 • edited by peol

FredrikFolkesson left a comment

Choose a reason for hiding this comment

carlioth commented Apr 5, 2018 •

edited

FredrikFolkesson commented Apr 5, 2018 •

edited by peol