Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Added: getConnections, getConnection, removeApp, removeConnection. #104

Merged
merged 9 commits into from Dec 13, 2018

Conversation

FredrikFolkesson
Copy link
Contributor

This PR adds the possibility to remove connections and apps.
(Before you could only remove generic entities)

It also gives you the possibility to view what connectors are inside your app
corectl get connections and corectl get connection connection-id respectively.

We have a potential problem that some tests are dependent on running order (I.E first test creates the app, the next tests checks that there are objects inside the app)

I think this should be cleaned up, but it might take some time, and is not part of this issue.

This closes #102

main.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
test/corectl_integration_test.go Outdated Show resolved Hide resolved
@@ -27,6 +27,8 @@ Lists one or several resources
* [corectl](corectl.md) -
* [corectl get apps](corectl_get_apps.md) - Prints a list of all apps available in the current engine
* [corectl get assoc](corectl_get_assoc.md) - Print table associations summary
* [corectl get connection](corectl_get_connection.md) - Shows the properties for a specific connection
* [corectl get connections](corectl_get_connections.md) - Prints a list of all connections in the current app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does current app mean? Should it be "specified" app?

@@ -13,22 +13,22 @@ corectl remove dimensions <dimension-id>... [flags]
### Options

```
-h, --help help for dimensions
-a, --app string App name including .qvf file ending. If no app is specified a session app is used instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is .qvf needed?

Copy link
Member

@wennmo wennmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work! 👍

@FredrikFolkesson FredrikFolkesson merged commit 8c7d854 into master Dec 13, 2018
@FredrikFolkesson FredrikFolkesson deleted the support-delete branch December 18, 2018 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for deleting objects
3 participants