This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Added: getConnections, getConnection, removeApp, removeConnection. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns, get connection
wennmo
reviewed
Dec 12, 2018
docs/corectl_get.md
Outdated
@@ -27,6 +27,8 @@ Lists one or several resources | |||
* [corectl](corectl.md) - | |||
* [corectl get apps](corectl_get_apps.md) - Prints a list of all apps available in the current engine | |||
* [corectl get assoc](corectl_get_assoc.md) - Print table associations summary | |||
* [corectl get connection](corectl_get_connection.md) - Shows the properties for a specific connection | |||
* [corectl get connections](corectl_get_connections.md) - Prints a list of all connections in the current app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does current app mean? Should it be "specified" app?
docs/corectl_remove_dimensions.md
Outdated
@@ -13,22 +13,22 @@ corectl remove dimensions <dimension-id>... [flags] | |||
### Options | |||
|
|||
``` | |||
-h, --help help for dimensions | |||
-a, --app string App name including .qvf file ending. If no app is specified a session app is used instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is .qvf needed?
wennmo
approved these changes
Dec 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work! 👍
axelssonHakan
approved these changes
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to remove connections and apps.
(Before you could only remove generic entities)
It also gives you the possibility to view what connectors are inside your app
corectl get connections
andcorectl get connection connection-id
respectively.We have a potential problem that some tests are dependent on running order (I.E first test creates the app, the next tests checks that there are objects inside the app)
I think this should be cleaned up, but it might take some time, and is not part of this issue.
This closes #102