Cookieexample #82
Cookieexample #82
Conversation
|
Circleci behaved weird so had to push again |
|
The example looks good, but a couple of things are still needed. We need to add this example to the documentation https://github.com/qlik-oss/enigma-go/blob/master/examples/README.md Also add it to the CCI pipeline. That is done by adding the example to this script: https://github.com/qlik-oss/enigma-go/blob/master/examples/run_examples.sh Not sure if it's intentional but you have also generated a new qix-generated.go. Should be handled in a separate PR in my opinion. |
|
I reverted qix_generated.go to the one on master. |
examples/cookiejar/cookiejar.go
Outdated
| cookies := dialer.Jar.Cookies(urlTest) | ||
| for _, cookie := range cookies { | ||
| if cookie.Name == "_session" { | ||
| fmt.Println(cookie) |
There was a problem hiding this comment.
I think it would be nice if there was some additional information for context.
Maybe something as simple as "Cookies found:" before the cookies are printed.
|
Overall it looks good but I agree with @wennmo that some additional work is still needed. |
…ew readme and added the script to run_examples.sh
examples/cookiejar/README.md
Outdated
| @@ -0,0 +1,9 @@ | |||
| # Cookier Jar | |||
|
|
|||
| This example show you how to set a cookie jar to a enigma dialer. | |||
Add a simple cookiejar example