Skip to content

Commit

Permalink
fix: fix counting the number of dimensions in a filter pane
Browse files Browse the repository at this point in the history
  • Loading branch information
quanho committed Mar 6, 2023
1 parent 1ebdb00 commit 4eda87e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions apis/nucleus/src/components/Cell.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ const validateTarget = (translator, layout, properties, def) => {
const c = def.resolveLayout(layout);
const reqDimErrors = validateInfo(
minD,
getInfo(c.qDimensionInfo),
getInfo(c.qDimensionInfo || c.qItems),
(i) => def.dimensions.description(properties, i),
translator.get('Visualization.Invalid.Dimension'),
translator.get('Visualization.UnfulfilledCalculationCondition')
Expand Down Expand Up @@ -177,7 +177,7 @@ const validateCubes = (translator, targets, layout) => {
const minD = def.dimensions.min();
const minM = def.measures.min();
const c = def.resolveLayout(layout);
const d = getInfo(c.qDimensionInfo).filter(filterData); // Filter out optional calc conditions
const d = getInfo(c.qDimensionInfo || c.qItems).filter(filterData); // Filter out optional calc conditions
const m = getInfo(c.qMeasureInfo).filter(filterData); // Filter out optional calc conditions
aggMinD += minD;
aggMinM += minM;
Expand Down
4 changes: 2 additions & 2 deletions apis/supernova/src/qae.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,10 @@ const resolveValue = (data, reference, defaultValue) => {
function target(def) {
const propertyPath = def.path || '/qHyperCubeDef';
const layoutPath = propertyPath.slice(0, -3);
if (/\/(qHyperCube|qListObject)$/.test(layoutPath) === false) {
if (/\/(qHyperCube|qListObject|qChildList)$/.test(layoutPath) === false) {
const d = layoutPath.includes('/qHyperCube') ? 'qHyperCubeDef' : 'qListObjectDef';
throw new Error(
`Incorrect definition for ${d} at ${propertyPath}. Valid paths include /qHyperCubeDef or /qListObjectDef, e.g. data/qHyperCubeDef`
`Incorrect definition for ${d} at ${propertyPath}. Valid paths include /qHyperCubeDef, /qListObjectDef, or /qChildListDef, e.g. data/qHyperCubeDef`
);
}
return {
Expand Down

0 comments on commit 4eda87e

Please sign in to comment.