Skip to content

Commit

Permalink
fix: listobject pp component issues
Browse files Browse the repository at this point in the history
  • Loading branch information
Caele committed Aug 31, 2022
1 parent f5d9e83 commit 545e1fe
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions apis/nucleus/src/object/lo-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default function loHandler({ dc: lo, def, properties }) {

const handler = {
dimensions() {
if (!lo.qDef || !lo.qDef.qFieldDefs || lo.qDef.qFieldDefs.length === 0) return [];
if (!lo.qLibraryId && (!lo.qDef || !lo.qDef.qFieldDefs || lo.qDef.qFieldDefs.length === 0)) return [];
return [lo];
},
measures() {
Expand Down Expand Up @@ -46,9 +46,8 @@ export default function loHandler({ dc: lo, def, properties }) {
},
removeDimension(idx) {
const dimension = lo;
Object.keys(dimension).forEach((k) => {
delete lo[k];
});
delete lo.qDef;
delete lo.qLibraryId;
def.dimensions.removed(dimension, objectProperties, idx);
},
addMeasure() {},
Expand All @@ -61,7 +60,7 @@ export default function loHandler({ dc: lo, def, properties }) {
return 0;
},
canAddDimension() {
return lo.qDef && lo.qDef.qFieldDefs ? lo.qDef.qFieldDefs.length === 0 : !lo.qDef;
return handler.dimensions().length === 0;
},
canAddMeasure() {
return false;
Expand Down

0 comments on commit 545e1fe

Please sign in to comment.