fix: horizontal listbox

qlik-oss · Jun 23, 2022 · 70ff786 · 70ff786
1 parent f44fc1a
commit 70ff786
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/apis/nucleus/src/components/listbox/ListBoxInline.jsx b/apis/nucleus/src/components/listbox/ListBoxInline.jsx
@@ -244,8 +244,9 @@ export default function ListBoxInline({ app, fieldIdentifier, stateName = '$', o
   const showTitle = true;
 
   const searchVisible = (search === true || (search === 'toggle' && showSearch)) && !selectDisabled();
-
-  const minHeight = 49 + (searchVisible ? 40 : 0) + 49;
+  const searchHeight = dense ? 27 : 40;
+  const extraheight = dense ? 39 : 49;
+  const minHeight = 49 + (searchVisible ? searchHeight : 0) + extraheight;
 
   const onShowSearch = () => {
     const newValue = !showSearch;

diff --git a/apis/nucleus/src/components/listbox/ListBoxRowColumn.jsx b/apis/nucleus/src/components/listbox/ListBoxRowColumn.jsx
@@ -172,7 +172,8 @@ const Root = styled('div')(({ theme }) => ({
   },
 
   [`&.${classes.barContainer}`]: {
-    position: 'relative',
+    height: '100%',
+    display: 'inline-block',
   },
 
   [`& .${classes.bar}`]: {
@@ -208,14 +209,15 @@ const Root = styled('div')(({ theme }) => ({
   },
 }));
 
-function RowColumn({ index, style, data, column = false }) {
+function RowColumn({ index, style, data }) {
   const {
     onClick,
     onMouseDown,
     onMouseUp,
     onMouseEnter,
     pages,
     isLocked,
+    column = false,
     checkboxes = false,
     dense = false,
     frequencyMode = 'N',