Skip to content

Commit

Permalink
fix: leave freqmode alone (#1026)
Browse files Browse the repository at this point in the history 
* feat: enable frequency count property

* fix: refactor frequency count

* fix: refactor & change zero freq text

* fix: revert the frequencyMode changes

Co-authored-by: costa <costantino.marullo@qlik.com>
  • Loading branch information
@johanlahti
johanlahti and costa committed Dec 7, 2022
1 parent 179ed92 commit f644c35
Show file tree
Hide file tree
Showing 3 changed files with 181 additions and 181 deletions.
2 changes: 1 addition & 1 deletion apis/nucleus/src/index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ function nuked(configuration = {}) {
* @param {string=} options.title Custom title, defaults to fieldname
* @param {Direction=} [options.direction=ltr] Direction setting ltr|rtl.
* @param {ListLayout=} [options.listLayout=vertical] Layout direction vertical|horizontal
* @param {FrequencyMode=} [options.frequencyMode=N] Show frequency none|value|percent|relative
* @param {FrequencyMode=} [options.frequencyMode=none] Show frequency none|value|percent|relative
* @param {boolean=} [options.histogram=false] Show histogram bar
* @param {SearchMode=} [options.search=true] Show the search bar permanently or using the toggle button: false|true|toggle|toggleShow
* @param {boolean=} [options.toolbar=true] Show the toolbar
Expand Down
274 changes: 137 additions & 137 deletions apis/stardust/api-spec/spec.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@
"frequencyMode": {
"description": "Show frequency none|value|percent|relative",
"optional": true,
"defaultValue": "N",
"defaultValue": "none",
"type": "#/definitions/FrequencyMode"
},
"histogram": {
Expand Down Expand Up @@ -1068,115 +1068,6 @@
}
}
},
"Field": {
"kind": "alias",
"items": {
"kind": "union",
"items": [
{
"type": "string"
},
{
"type": "EngineAPI.INxDimension"
},
{
"type": "EngineAPI.INxMeasure"
},
{
"type": "#/definitions/LibraryField"
}
]
}
},
"CreateConfig": {
"description": "Rendering configuration for creating and rendering a new object",
"extends": [
{
"type": "#/definitions/BaseConfig"
}
],
"kind": "interface",
"entries": {
"type": {
"type": "string"
},
"version": {
"optional": true,
"type": "string"
},
"fields": {
"optional": true,
"kind": "union",
"items": [
{
"kind": "array",
"items": {
"type": "#/definitions/Field"
}
}
]
},
"properties": {
"optional": true,
"type": "EngineAPI.IGenericObjectProperties"
}
}
},
"BaseConfig": {
"description": "Basic rendering configuration for rendering an object",
"kind": "interface",
"entries": {
"element": {
"type": "HTMLElement"
},
"options": {
"optional": true,
"type": "object"
},
"plugins": {
"optional": true,
"kind": "array",
"items": {
"type": "#/definitions/Plugin"
}
}
}
},
"GetConfig": {
"description": "Rendering configuration for rendering an existing object",
"extends": [
{
"type": "#/definitions/BaseConfig"
}
],
"kind": "interface",
"entries": {
"id": {
"type": "string"
}
}
},
"LibraryField": {
"kind": "interface",
"entries": {
"qLibraryId": {
"type": "string"
},
"type": {
"kind": "union",
"items": [
{
"kind": "literal",
"value": "'dimension'"
},
{
"kind": "literal",
"value": "'measure'"
}
]
}
}
},
"AppSelections": {
"kind": "class",
"constructor": {
Expand Down Expand Up @@ -1374,48 +1265,112 @@
}
}
},
"LoadType": {
"kind": "interface",
"params": [
{
"name": "type",
"kind": "object",
"entries": {
"name": {
"type": "string"
},
"version": {
"type": "string"
}
}
}
],
"returns": {
"type": "Promise",
"generics": [
"Field": {
"kind": "alias",
"items": {
"kind": "union",
"items": [
{
"type": "#/definitions/Visualization"
"type": "string"
},
{
"type": "EngineAPI.INxDimension"
},
{
"type": "EngineAPI.INxMeasure"
},
{
"type": "#/definitions/LibraryField"
}
]
},
"entries": {}
}
},
"TypeInfo": {
"CreateConfig": {
"description": "Rendering configuration for creating and rendering a new object",
"extends": [
{
"type": "#/definitions/BaseConfig"
}
],
"kind": "interface",
"entries": {
"name": {
"type": {
"type": "string"
},
"version": {
"optional": true,
"type": "string"
},
"load": {
"type": "#/definitions/LoadType"
"fields": {
"optional": true,
"kind": "union",
"items": [
{
"kind": "array",
"items": {
"type": "#/definitions/Field"
}
}
]
},
"meta": {
"properties": {
"optional": true,
"type": "EngineAPI.IGenericObjectProperties"
}
}
},
"BaseConfig": {
"description": "Basic rendering configuration for rendering an object",
"kind": "interface",
"entries": {
"element": {
"type": "HTMLElement"
},
"options": {
"optional": true,
"type": "object"
},
"plugins": {
"optional": true,
"kind": "array",
"items": {
"type": "#/definitions/Plugin"
}
}
}
},
"GetConfig": {
"description": "Rendering configuration for rendering an existing object",
"extends": [
{
"type": "#/definitions/BaseConfig"
}
],
"kind": "interface",
"entries": {
"id": {
"type": "string"
}
}
},
"LibraryField": {
"kind": "interface",
"entries": {
"qLibraryId": {
"type": "string"
},
"type": {
"kind": "union",
"items": [
{
"kind": "literal",
"value": "'dimension'"
},
{
"kind": "literal",
"value": "'measure'"
}
]
}
}
},
Expand Down Expand Up @@ -1446,6 +1401,51 @@
"const plugin = {\n info: {\n name: \"example-plugin\",\n type: \"meta-type\",\n },\n fn: () => {\n // Plugin implementation goes here\n }\n};"
]
},
"LoadType": {
"kind": "interface",
"params": [
{
"name": "type",
"kind": "object",
"entries": {
"name": {
"type": "string"
},
"version": {
"type": "string"
}
}
}
],
"returns": {
"type": "Promise",
"generics": [
{
"type": "#/definitions/Visualization"
}
]
},
"entries": {}
},
"TypeInfo": {
"kind": "interface",
"entries": {
"name": {
"type": "string"
},
"version": {
"optional": true,
"type": "string"
},
"load": {
"type": "#/definitions/LoadType"
},
"meta": {
"optional": true,
"type": "object"
}
}
},
"ActionToolbarElement": {
"availability": {
"since": "2.1.0"
Expand Down
Loading

0 comments on commit f644c35

Please sign in to comment.