fix(supernova): update all options (#391)

qlik-oss · Apr 1, 2020 · f9d5e4b · f9d5e4b
1 parent 63d8cc1
commit f9d5e4b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/apis/supernova/__tests__/unit/creator.spec.js b/apis/supernova/__tests__/unit/creator.spec.js
@@ -292,6 +292,12 @@ describe('creator', () => {
         },
       });
       expect(hooked.run.callCount).to.equal(3);
+
+      expect(c.context.options).to.eql({
+        rtl: false,
+        foo,
+        ref,
+      });
     });
 
     it('should run when theme name has changed', () => {

diff --git a/apis/supernova/src/creator.js b/apis/supernova/src/creator.js
@@ -106,8 +106,8 @@ function createWithHooks(generator, opts, galaxy) {
           const op = {};
           let opChanged = false;
           Object.keys(r.options).forEach(key => {
+            op[key] = r.options[key];
             if (this.context.options[key] !== r.options[key]) {
-              op[key] = r.options[key];
               opChanged = true;
             }
           });