Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make enigma mocker properly internal #1047

Merged
merged 2 commits into from Jan 12, 2023
Merged

chore: make enigma mocker properly internal #1047

merged 2 commits into from Jan 12, 2023

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Jan 11, 2023 •
edited

Motivation

Engima mocker had its own build stuff when it isn't needed, I think that messes up the typings.

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@Caele Caele requested a review from a team January 11, 2023 09:38
@Caele Caele merged commit 310f764 into master Jan 12, 2023
@Caele Caele deleted the tsm/mocker-internal branch January 12, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veinfors veinfors veinfors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Caele @veinfors