Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update templates to use inline ext #1058

Merged
merged 2 commits into from Jan 23, 2023
Merged

chore: update templates to use inline ext #1058

merged 2 commits into from Jan 23, 2023

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Jan 18, 2023 •
edited

Motivation

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@T-Wizard
Copy link
Collaborator

with inline ext you can/should also remove the --ext src/ext.js parameter in the sense commant in the template package.json
here:

nebula.js/commands/create/templates/sn/none/_package.json

Line 21 in 6695ee8

"sense": "nebula sense --ext src/ext.js --meta src/meta.json",

@Caele Caele requested a review from a team January 23, 2023 11:06
@Caele Caele merged commit 1bec44c into master Jan 23, 2023
@Caele Caele deleted the tsm/update-templats branch January 23, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Wizard T-Wizard T-Wizard approved these changes

@veinfors veinfors veinfors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Caele @T-Wizard @veinfors