Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: created object now can extend initial properties #1063

Merged
merged 4 commits into from Jan 30, 2023
Merged

feat: created object now can extend initial properties #1063

merged 4 commits into from Jan 30, 2023

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Jan 26, 2023

Motivation

When rendering new object you are forced to specify entire property branches as the initial props are merged, not deeply extended.

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@Caele Caele changed the title fix!: created object now extend initial properties feat: created object now extend initial properties Jan 27, 2023
@Caele Caele changed the title feat: created object now extend initial properties feat: created object now can extend initial properties Jan 27, 2023
@Caele Caele merged commit c14a1e6 into master Jan 30, 2023
@Caele Caele deleted the tsm/failsae branch January 30, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veinfors veinfors veinfors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Caele @veinfors