Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix filter pane header change the height on selection #1124

Merged
merged 3 commits into from
Mar 11, 2023
Merged

fix: fix filter pane header change the height on selection #1124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d2ebae
fix: fix filter pane header change the height on selection
quanho Mar 10, 2023
bc2a6ef
refactor: refactor
quanho Mar 11, 2023
a18317a
refactor: refactor
quanho Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion apis/nucleus/src/components/listbox/ListBoxInline.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ function ListBoxInline({ options, layout }) {
const searchHeight = dense ? 27 : 40;
const extraheight = dense ? 39 : 49;
const minHeight = 49 + (searchVisible ? searchHeight : 0) + extraheight;
const headerHeight = 32;
const { wildCardSearch, searchEnabled } = layout;

const onShowSearch = () => {
Expand All @@ -209,7 +210,7 @@ function ListBoxInline({ options, layout }) {
>
{toolbar && (
<Grid item container style={{ padding: theme.spacing(1) }} wrap="nowrap">
<Grid item container wrap="nowrap">
<Grid item container height={headerHeight} wrap="nowrap">
<Grid item sx={{ display: 'flex', alignItems: 'center', width: searchIconWidth }}>
{isLocked ? (
<IconButton tabIndex={-1} onClick={unlock} disabled={!isLocked} size="large">
Expand Down