fix: align search icons and cells #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanho
requested review from
johanlahti,
DanielS-Qlik,
veinfors,
T-Wizard and
Caele
veinfors
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since now a header can contains many icons like search icon/lock icon and/or drill-down icon, so we also need to align the search icon in the header with the search icon in the search box and also need to align these icons with cells to have the same paddingLeft.
Before (search icons do not align well):
After:
Without a drill-down icon
With a drill-down icon
Motivation
Requirements checklist
yarn specWhen build and tests have passed: