fix(Listbox): take searchEnabled and toolbar into account for minHeight #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add rendering tests please to cover this case |
# Conflicts: # apis/nucleus/src/components/listbox/ListBoxInline.jsx # test/rendering/listbox/listbox.js
johanlahti
reviewed
Mar 17, 2023
johanlahti
approved these changes
Mar 17, 2023
Co-authored-by: Johan Lahti <johanlahti@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve rendering small size Listbox, take searchEnabled and toolbar into account when calculating minHeight
As a first step to fixing: qlik-oss/sn-list-objects#89
Before:
After:
Requirements checklist
yarn specWhen build and tests have passed: