-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Listbox): rtl mode #1144
fix(Listbox): rtl mode #1144
Conversation
I have updated the snapshots for rendering tests, have added unit tests for RTL case. Can look into adding rendering tests. |
I meant that the changes you have made should not affect the current rendering tests, so was there an intentional style update there somewhere or? |
Have introduced a right padding for header. |
Motivation
RTL mode for the ListBox. This is to fix qlik-oss/sn-list-objects#82
Before: Title, Search Icon, Columns & Toolbar were not correctly aligned for Folded as well as normal ListBox.
Number Alignment was not correct & - sign for negative numbers shown backwards.
After: Attached Screenshots
Litbox Title, Search Glass & Columns with Numeric positive negative as well as String values in RTL mode :
Actions Toolbar in RTL Mode :
Folded ListBox in RTL Mode :
Requirements checklist
yarn spec
When build and tests have passed: