Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use same text color for excluded and selectedExcluded #1147

Merged
merged 3 commits into from Mar 15, 2023

Conversation

T-Wizard
Copy link
Collaborator

@T-Wizard T-Wizard commented Mar 15, 2023

use same text color for excluded and selectedExcluded.
fix missing lock icon for Locked Excluded state
add rendering tests for all listbox states

Motivation

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@T-Wizard T-Wizard force-pushed the selected-excluded-text-color branch from f4446b9 to 226d30d Compare March 15, 2023 12:04
@T-Wizard T-Wizard force-pushed the selected-excluded-text-color branch from 226d30d to cab4fae Compare March 15, 2023 12:15
@T-Wizard T-Wizard marked this pull request as ready for review March 15, 2023 12:33
@T-Wizard T-Wizard merged commit 48c85d4 into master Mar 15, 2023
@T-Wizard T-Wizard deleted the selected-excluded-text-color branch March 15, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants