feat: fetch frequencyMax #1152
Merged
feat: fetch frequencyMax #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Wizard
force-pushed
the
fetch-frequencyMax
branch
from
0d9e488
to
6f8c062
Compare
quanho
reviewed
Mar 16, 2023
quanho
reviewed
Mar 16, 2023
quanho
approved these changes
Mar 16, 2023
T-Wizard
force-pushed
the
fetch-frequencyMax
branch
from
6f8c062
to
a41fbff
Compare
T-Wizard
force-pushed
the
fetch-frequencyMax
branch
from
a41fbff
to
1ebfa20
Compare
DanielS-Qlik
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do an extra app.evaluateEx call to fetch frequencyMax when it is set to the value 'fetch'
update useOnTheFlyModel.jsx to only frequencyMax when actually needed
update useOnTheFlyModel.jsx to use it for drilldowns (maybe use it all library dimensions?)
Motivation
For use with library dimensions as it is not possible for a static qValueExpression to handle that the library dimension changes field it uses (common for drilldowns but possible for any lib dimension)
the use of a marker value to trigger is are because without it there is not enough information in the layout to know if frequencyMax needs to be fetched.
Requirements checklist
yarn specWhen build and tests have passed: