fix: fix getting listbox theme #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielS-Qlik
approved these changes
Mar 17, 2023
|
It broke a lot of rendering test |
Caele
force-pushed
the
hva/sn-filter-pane-78
branch
from
31b70d6
to
0b85929
Compare
Caele
reviewed
Mar 17, 2023
| @@ -144,6 +144,7 @@ export default function ListBoxSearch({ | |||
| sx={[ | |||
| { | |||
| border: 'none', | |||
| fontSize: 14, | |||
There was a problem hiding this comment.
Added this as well to the search field isn't huge compared to the rest
T-Wizard
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix getting theme for listbox.
This is to fix qlik-oss/sn-list-objects#78.
There is still another problem of theme inheriting in nebula.js. E.g. Breeze theme has no font-family defined for listbox so it should inherit from Sense classic theme. This will be fixed in another PR.
Requirements checklist
yarn specWhen build and tests have passed: