fix(Listbox): no box-shadow on hover #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veinfors
approved these changes
Mar 20, 2023
|
In (maybe) the slightly longer perspective I think we want the more complicated solution of not stealing focus on hover |
|
Yes, in the old listbox the "virtual scroll" from sense is used to enable the user to scroll with the keyboard on hover. But it seems to involve quite a lot of work. |
Caele
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Don't add box-shadow on hover.
Fixes qlik-oss/sn-list-objects#170
Before:
After:
Requirements checklist
yarn specWhen build and tests have passed: