Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pick up enigmaMockerOptions from fixture #1165

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Conversation

veinfors
Copy link
Collaborator

@veinfors veinfors commented Mar 20, 2023

Makes it possible to pass in options to enigmaMocker even when using it indirectly through nebula serve by picking up enigmaMockerOptions from the root of the fixture.

@DanielS-Qlik
Copy link
Contributor

Maybe add a note about it in this example:

Generic objects to render visualization with. The objects are used as input to `EnigmaMocker` to base mock upon. See `@nebula.js/enigma-mocker` for more details.

@veinfors veinfors changed the title feat: pick up enigmaOptions from fixture feat: pick up enigmaMockerOptions from fixture Mar 20, 2023
@veinfors
Copy link
Collaborator Author

Maybe add a note about it in this example:

Generic objects to render visualization with. The objects are used as input to `EnigmaMocker` to base mock upon. See `@nebula.js/enigma-mocker` for more details.

Good point, did that!

@veinfors veinfors merged commit 39ec748 into master Mar 20, 2023
@veinfors veinfors deleted the enigma-options branch March 20, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants