Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update enigma #1169

Merged
merged 2 commits into from Mar 21, 2023
Merged

chore: update enigma #1169

merged 2 commits into from Mar 21, 2023

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Mar 21, 2023

Motivation

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@niekvanstaveren
Copy link
Collaborator

This is good, but we probably also want to update the schemas that are imported everywhere:
e.g. https://github.com/qlik-oss/nebula.js/blob/master/commands/serve/web/connect.js#L2

@Caele
Copy link
Collaborator Author

Caele commented Mar 21, 2023

yea, thought I did that, good catch

@Caele Caele requested a review from a team March 21, 2023 11:48
@Caele Caele merged commit 48736a8 into master Mar 21, 2023
@Caele Caele deleted the tsm/upd-enigma branch March 21, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veinfors veinfors veinfors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Caele @niekvanstaveren @veinfors