Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: chart bg colors and title styles from properties and theme #1183

Merged
merged 13 commits into from Mar 28, 2023
Merged

feat: chart bg colors and title styles from properties and theme #1183

merged 13 commits into from Mar 28, 2023

Conversation

Caele
Copy link
Collaborator

@Caele Caele commented Mar 23, 2023 •
edited

Motivation

Fixes so that charts follow theme and property stylings for background and titles.

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@Caele Caele changed the title fix: show correct bg color from theme feat: chart bg colors and title styles from properties and theme Mar 24, 2023
@Caele Caele marked this pull request as ready for review March 27, 2023 09:39
@Caele Caele requested a review from a team March 27, 2023 09:40
@Caele Caele merged commit 65af640 into master Mar 28, 2023
10 checks passed
@Caele Caele deleted the tsm/bg-and-title-fixes branch March 28, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Caele